Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More node version for testing #4

Merged
merged 6 commits into from
Sep 28, 2017
Merged

More node version for testing #4

merged 6 commits into from
Sep 28, 2017

Conversation

gits2501
Copy link
Owner

No description provided.

@gits2501
Copy link
Owner Author

gits2501 commented Sep 28, 2017

Attempting to remedy (braking) changes considering crypto lib in node >=6.0.0. Where all crypto methods deafult encoding is set to utf-8. Info here node#5522.

  1. A guy introduces breaking change without realising it.

  2. Pointing to it by more experienced member.

  3. How this got to be merged?

@gits2501 gits2501 merged commit e5afb8c into master Sep 28, 2017
@gits2501
Copy link
Owner Author

Issue addressed, hmac_sha1 works in all node versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant